-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust] Support formParams and fix list-params. #1678
Conversation
Form params were previously unsupported, and list-params would produce code that didn't compile.
@wing328 thanks for taking care of the test updates. |
@mfarrugi you're welcome. Thanks again for the PR. |
My bad. The CI failed with the following:
@mfarrugi can you please take a look when you've time? |
FYI. I've disabled the test for the time being: https://github.com/OpenAPITools/openapi-generator/blob/master/pom.xml |
There are two problems:
I see that the hyper implementation uses I won't get to this for at least a week because of the holidays. The change should be reverted pending fixes. |
Please enjoy the holidays. We'll revert the change for the time being. |
@mfarrugi thanks for the contribution, which has been included in the 4.0.0-beta release: https://twitter.com/oas_generator/status/1079727020374806529. Happy New Year and looking forward to more collaboration and contributions in 2019! |
* [Rust] Support formParams and fix list-params. Form params were previously unsupported, and list-params would produce code that didn't compile. * update rust samples
…#1732) * Revert "Disable rust-reqwest petstore test" This reverts commit 9e1cce2. * Revert "Fix various CI issues (OpenAPITools#1722)" This reverts commit 77270a0. * Revert "[Rust] Support formParams and fix list-params. (OpenAPITools#1678)" This reverts commit 4a494b4.
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,. Default:3.4.x
,4.0.x
master
.@frol @farcaller @bjgill
Description of the PR
Form params were previously unsupported, and list-params would produce code that didn't compile.
Tested against a private protocol that uses
I'll follow up with the Petstore sample updates a little later.